Cleanup: Remove "using namespace std;" and add constness to searches. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks. This is a great cleanup! I just have one question before I merge. I'm a bit concerned about the effect of const-ness. Would you describe the objective of this part of the change? |
|
Sure thing. I added the constness because the search functionality doesn't modify the data, so, for example, a function should be able to take a const IntervalTree<T,K>& as an argument and query it. Without the constness, the compiler wouldn't allow you to query a const IntervalTree<T,K> even though querying it doesn't actually modify it. The namespace stuff is because headers should never do "using namespace ...;" since it pollutes the global namespace. |
ekg
added a commit
that referenced
this pull request
Oct 8, 2014
Cleanup: Remove "using namespace std;" and add constness to searches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also new instead of malloc.