Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo for stable #47

Open
14 tasks done
PeeHaa opened this issue Sep 8, 2020 · 1 comment
Open
14 tasks done

Todo for stable #47

PeeHaa opened this issue Sep 8, 2020 · 1 comment

Comments

@PeeHaa
Copy link
Collaborator

PeeHaa commented Sep 8, 2020

  • Do we really need auryn? Or is it easier to just build the deps ourselves as we do not have a deep stack?
  • We need to allow users to have the server listen on several ips/ports (an exampleis both ipv4 and ipv6 support)
  • Abstract the server away in its own class
  • Maybe abstract the special repositories to a dedicated class instead of repeating it (maybe even make it a config?)
  • Change new Type(1), etc to not make use of magic numbers
  • Make exception extend the base project exception instead of the global \Exception
  • Instead of asking for a concrete HttpClient class maybe ask for an interface instead?
  • Everything that returns a \Generator right now should return a Promise
  • 2f48b31#diff-1b3db3c3ba01baa1e657a2965f6771a6R30 should not be nullable, but instead be an empty results
  • Instead ofusing the onclose on the client (2f48b31#diff-1b3db3c3ba01baa1e657a2965f6771a6R52) we can just log the disconnect after this loop 2f48b31#diff-1b3db3c3ba01baa1e657a2965f6771a6R77
    • No we do not, currently the websocket server does not handle disconnects correctly
  • Test with lowest deps
  • Test with highest deps
  • Test with php 8 if travis made a working image yet
  • Set up phpcs
@ekinhbayar
Copy link
Owner

ekinhbayar commented Sep 13, 2020

Here's an example for supporting SSL on http-server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants