Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event-switch): add a graceful stop to the EventSwitch #5

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

fthouraud
Copy link
Contributor

It allows the EventSwitch to be closed only after all events have been read then received by all the receivers.

The setState method has been improved. The loop over all the states is now skipped if the new state is either Aborted or Emitted.

I've also:

  • cleaned up the code
  • improved documentation
  • fixed the test for massive events (it was only using 1 receiver instead of 10)

@fthouraud fthouraud force-pushed the feat/graceful-shutdown branch 3 times, most recently from f290f89 to 1c84e85 Compare April 29, 2020 09:23
@codecov-io
Copy link

Codecov Report

Merging #5 into master will increase coverage by 1.56%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   75.81%   77.38%   +1.56%     
==========================================
  Files           7        7              
  Lines         612      650      +38     
==========================================
+ Hits          464      503      +39     
  Misses        107      107              
+ Partials       41       40       -1     
Impacted Files Coverage Δ
godim.go 70.93% <70.00%> (-0.87%) ⬇️
event.go 76.11% <89.21%> (+5.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22fde0...287aa6b. Read the comment docs.

@nprudhomme nprudhomme merged commit 414f064 into ekino:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants