Allow bits to be built for GHCJS #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 13, 2014 09:18
GHCJS of course cannot link to C files, so when compiling there load those byte arrays into ByteStrings instead of using the FFI.
Make it a cabal flag and centralize the conditional on ghcjs.
From Python because it's likely to be everywhere and Cabal makes it annoying to write a pre-build code generator.
|
7 years later I suppose I should probably merge this. ;) |
|
Heh, maybe. GHCJS isn't super important to me anymore, alas, but maybe it'd be useful for someone! |
|
I worry that some of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHCJS doesn't support linking to C, naturally, so I made
Data.Bits.Extrasoptionally useunsafeIndexintoByteStrings instead of linking to static C arrays.Now that the tables exist in both C and Haskell, there is a generator script to produce them both so that the canonical list of magic numbers can be in only one place. Cabal doesn't really have great support (or indeed as far as I can tell, any support) for ad-hoc pre-build code generation like this, so it's a Python program with the outputs checked in.