Fix reversed branches in parsnip's scan
#10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've noticed the conditions passed to
while
andtill
seem to need to be inverted - but then in some cases the parsing would never stop till a SEGFAULT was reached.This fixes the need to invert conditions in
while
,till
and other dependents, and removes the SEGFAULT. See the added tests:To further test the library, and validate my original goal, I've ported most of
cassava
to useparsnip
instead ofattoparsec
, see:https://github.com/ArturGajowy/parsnip-cassava/commits/master
All tests passed, save for '\0' in input (those were changed), and the Streaming and Incremental APIs (didn't port those, disabled the tests).
Somehow the benchmarks did not show improvement - rather a regression in some cases.
Possible reasons I see:
toStrict
the input ByteString, as cassava parses lazy ByteString-sFor use as a cassava backend, one would further need:
parsnip-cassava
I'd love to hear your thoughts :) Hope the PR is helpful! :)