Glow uniforms #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hacked together a test where I passed in an array of vec3 into a shader, and it all seems to work correctly. |
|
I'll kill the now-superfluous parens, but no issue merging. |
|
The main reason I haven't run into the need for at least the odd shaped matrices here is that I long ago internalized the rules for what has what size in STD140, so i just never even really noticed they were missing. That said, the ones for doubles and ints, etc. and the uniformity of it all are all very welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I'm gonna need the other uniform functions soon, so I'm adding them now. These haven't been tested, just typechecked; I'm not sure I quite grok the
Storablestuff yet.