-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New operators not exported by Control.Lens.Operators #1067
Comments
Yes, I think we should re-export these from
Sorry about that! I wrote the
Thoughts, @ncaq? |
I think it is a good policy to export. |
OK. Regarding the Lines 1195 to 1201 in 1ce86ea
The Haddocks talk about appending an element to the end, but the implementation prepends to the front instead. As such, I think we need to correct both the Haddocks and the |
This prepend to the front rather than appending at the back. Spotted in #1067.
I've submitted a fix in #1068. |
This prepend to the front rather than appending at the back. Spotted in #1067.
This prepend to the front rather than appending at the back. Spotted in #1067.
I copied and pasted the basic part thinking it was basically the same and unlike it, prepend to the head side... |
No problem at all, @ncaq. Thank you for your contribution! |
And thank you for yours. |
These operators, introduced in
lens-5.3
, are not re-exported throughControl.Lens.Operators
:append an element to the backprepend an element to the front via (<>).(<<>:~)
appears misdocumented in the changelog: it is actually left-side<>
and-return-resultShould these lenses also have
<<
variants which return the old value?Ping @ncaq
The text was updated successfully, but these errors were encountered: