-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GHC 8.0 as the minimum #977
Conversation
I run a dependency lower bound checker, and the lower bounds for following dependencies can be bumped.
I.e. solver was not able to find an install plan with lower versions for these dependencies (with any GHC>=8.0). I haven't checke whether we have CPP related to these versions, but it would help solver to be a slightly faster alone by pruning the search space earlier. (there is MIN_VERSION_mtl at least). |
Thanks for checking! I'm a bit confused as to how the lower bound checker arrived at |
I used GHC-8.0.2. (And wouldn't mind if GHC-8.0.1 is excluded - I don't want to remember what bugs it had) |
Very well. I'll update this to require GHC 8.0.2 (not 8.0.1) as the minimum soon. |
These are automatically derived in modern versions of GHC.
4443c69
to
60bf7b0
Compare
@RyanGlScott yes, i have wondered whether it's |
It's only one data point, but I haven't seen this happen in any CI jobs for |
In any case, one of the GHC 8.0.2 builds did succeed, so I'm going to just merge this. |
The `plated` benchmark suite previously had a dependency on `base-compat`, which was introduced in #909 for compatibility with pre-7.10 versions of GHC. In #977, however, the minimum version of GHC was raised to 8.0, which means that there is no longer any reason for these benchmarks to depend on `base-compat`. This patch removes the dependency.
This drops support for GHC 7.8 and 7.10, which allows us to clean up lots of code in the process.
Fixes #928. Fixes #964.