Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rejigger Representational constraints #8

Closed
treeowl opened this issue Sep 9, 2018 · 0 comments
Closed

Rejigger Representational constraints #8

treeowl opened this issue Sep 9, 2018 · 0 comments

Comments

@treeowl
Copy link
Collaborator

treeowl commented Sep 9, 2018

I thought I put them where they wouldn't get in the way too much, but I was wrong. Under the current regime, we'd need them for (rank 2) maps and traversals, which is evil. So I need to fix that. Probably move them to the lookup side.
treeowl added a commit to treeowl/stable-maps that referenced this issue Sep 9, 2018
@treeowl
Add traversals
4fb97b8 
* Add `hmap`, `hfoldMap`, and `htraverse` for `StableName.Map`.

* Rejigger `Representational` constraints so `hmap` and `htraverse`
  aren't unreasonably constrained.

Closes ekmett#8

This also goes a long way toward resolving ekmett#1. The only remaining
discrepancy I see is `fromList`. One option might be to follow
`dependent-map`.
@treeowl treeowl mentioned this issue Sep 9, 2018
Merged
treeowl added a commit to treeowl/stable-maps that referenced this issue Sep 9, 2018
@treeowl
Add traversals
564cf5c 
* Add `hmap`, `hfoldMap`, and `htraverse` for `StableName.Map`.

* Rejigger `Representational` constraints so `hmap` and `htraverse`
  aren't unreasonably constrained.

Closes ekmett#8

This also goes a long way toward resolving ekmett#1. The only remaining
discrepancy I see is `fromList`. One option might be to follow
`dependent-map`.
treeowl added a commit that referenced this issue Sep 10, 2018
@treeowl
Add traversals (#9)
7d3b9c1 
* Add `hmap`, `hfoldMap`, and `htraverse` for `StableName.Map`.

* Rejigger `Representational` constraints so `hmap` and `htraverse`
  aren't unreasonably constrained.

Closes #8

This also goes a long way toward resolving #1. The only remaining
discrepancy I see is `fromList`. One option might be to follow
`dependent-map`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@treeowl