add test for invalid key

eko · Aug 17, 2020 · 9e5334e · 9e5334e
1 parent a7ab8a7
commit 9e5334e
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/store/freecache_test.go b/store/freecache_test.go
@@ -81,7 +81,7 @@ func TestFreecacheGetNotFound(t *testing.T) {
 	assert.Nil(t, value)
 }
 
-func TestFreecacheGetInvalidKey(t *testing.T) {
+func TestFreecacheGetWithInvalidKey(t *testing.T) {
 	// Given
 	ctrl := gomock.NewController(t)
 	defer ctrl.Finish()
@@ -90,8 +90,9 @@ func TestFreecacheGetInvalidKey(t *testing.T) {
 
 	s := NewFreecache(client, nil)
 
-	_, err := s.Get([]byte("key1"))
+	value, err := s.Get([]byte("key1"))
 	assert.Error(t, err, "key type not supported by Freecache store")
+	assert.Nil(t, value)
 }
 
 func TestFreecacheGetWithTTL(t *testing.T) {
@@ -166,6 +167,21 @@ func TestFreecacheGetWithTTLWhenErrorAtTTL(t *testing.T) {
 	assert.Equal(t, 0*time.Second, ttl)
 }
 
+func TestFreecacheGetWithTTLWhenInvalidKey(t *testing.T) {
+	// Given
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+
+	client := mocksStore.NewMockFreecacheClientInterface(ctrl)
+
+	s := NewFreecache(client, nil)
+
+	value, ttl, err := s.GetWithTTL([]byte("key1"))
+	assert.Error(t, err, "key type not supported by Freecache store")
+	assert.Nil(t, value)
+	assert.Equal(t, 0*time.Second, ttl)
+}
+
 func TestFreecacheSet(t *testing.T) {
 	// Given
 	ctrl := gomock.NewController(t)