Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert simple classes that mainly just store data to records #315

Open
ekolis opened this issue Jun 9, 2024 · 1 comment
Open

Convert simple classes that mainly just store data to records #315

ekolis opened this issue Jun 9, 2024 · 1 comment
Labels
technical debt Things that would make the code cleaner but deliver little to no value to users.
Milestone

Comments

@ekolis
Copy link
Owner

ekolis commented Jun 9, 2024

What needs to be cleaned up?

There are a lot of simple classes that mainly just store some data and don't have much in the way of references to other classes that need to maintain referential integrity. Convert them to data classes. Umm, I mean, records, this is not Kotlin!

How will this benefit us?

Records are supposed to have better performance than classes I think? And the syntax is simpler since properties can be converted to constructor parameters and equals/hashcode/etc are auto-implemented.

What potential drawbacks are there to making this change?

Just the time consumed doing it and any potential bugs introduced. Also records are immutable so that could be a problem.

@ekolis ekolis added the technical debt Things that would make the code cleaner but deliver little to no value to users. label Jun 9, 2024
@ekolis ekolis added this to the alpha-10 milestone Jun 9, 2024
@ekolis ekolis added this to FrEee Core Jun 9, 2024
@github-project-automation github-project-automation bot moved this to To do in FrEee Core Jun 9, 2024
@ekolis
Copy link
Owner Author

ekolis commented Jun 9, 2024

Perhaps this could be a first step toward implementing #312?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Things that would make the code cleaner but deliver little to no value to users.
Projects
Status: To do
Development

No branches or pull requests

1 participant