Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try to resolve the package path #31

Merged
merged 1 commit into from
Jan 29, 2017
Merged

fix: try to resolve the package path #31

merged 1 commit into from
Jan 29, 2017

Conversation

cecilia-sanare
Copy link
Contributor

  • This will resolve it globally or locally

Opted for a bin file similar to polymer-cli

closes #30

- This will resolve it globally or locally
Copy link
Owner

@ekristen ekristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I'll test it out when I'm back at my computer. Just curious in what scenario did the original way not work for you?

@cecilia-sanare
Copy link
Contributor Author

It didn't work if I installed it as a package dependency.

If I installed it globally it worked fine.

I also have a bit more information in the related issue.

@ekristen
Copy link
Owner

Nevermind I just saw the issue you opened. I'd still like to see how you were using it for my own education. Thanks.

@ekristen ekristen merged commit dcb5061 into ekristen:master Jan 29, 2017
@ekristen
Copy link
Owner

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work when installed as a package dependency
2 participants