Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account-blocklist deprecation message #65

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

darkowlzz
Copy link
Contributor

It logged account-blocklist as account-blacklist before.

For a config with account-blocklist

account-blocklist:
- "999999999999"

Before:

$ ./aws-nuke run -c nuke-cfg.yaml
WARN[0000] deprecated configuration key 'account-blacklist' - please use 'blocklist' instead  component=config
> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID XXXXX and the alias 'xxxxx'?
Do you want to continue? Enter account alias to continue.

After:

$ ./aws-nuke run -c nuke-cfg.yaml
WARN[0000] deprecated configuration key 'account-blocklist' - please use 'blocklist' instead  component=config
> aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID XXXXX and the alias 'xxxxx'?
Do you want to continue? Enter account alias to continue.

@darkowlzz darkowlzz changed the title Fix account-blocklist deprecation message fix: account-blocklist deprecation message Jun 24, 2024
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (6bcf973) to head (4946f2b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          17       17           
  Lines        1072     1072           
=======================================
  Hits         1048     1048           
  Misses         13       13           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekristen
Copy link
Owner

ekristen commented Jul 6, 2024

@darkowlzz can you rebase when you get a minute this will fix the tests so that they pass.

It logged account-blocklist as account-blacklist.
@darkowlzz
Copy link
Contributor Author

Rebased 🙂

@ekristen ekristen merged commit 64c441c into ekristen:main Jul 9, 2024
6 checks passed
@ekristen
Copy link
Owner

ekristen commented Jul 9, 2024

🎉 This issue has been resolved in version 0.17.2 🎉

The release is available on GitHub release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants