Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(properties): support time as a property type converting to rfc3339 #67

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ekristen
Copy link
Owner

@ekristen ekristen commented Jul 9, 2024

This adds support for time.Time as a property type when building from a struct. Removes the need to format it ahead of time and pass in as a string.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (e99126b) to head (fb9a96a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   97.76%   97.78%   +0.02%     
==========================================
  Files          17       17              
  Lines        1072     1084      +12     
==========================================
+ Hits         1048     1060      +12     
  Misses         13       13              
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekristen ekristen merged commit 71dd5d0 into main Jul 9, 2024
6 checks passed
@ekristen ekristen deleted the feat-props-time branch July 9, 2024 23:42
@ekristen
Copy link
Owner Author

ekristen commented Jul 9, 2024

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on GitHub release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant