-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kube2iam/kiam/kube-aws-iam-controller support #398
Comments
The third possible solution would be to add As the role name is now known beforehand, you can establish trust relationship containing the role name before creating the cluster, which simplifies the setup when you use kube2iam/kiam/kube-aws-iam-controller. The implementation can be done in cfn stack templates by setting |
Then, it may make more sense to add |
This adds two flags and one nodegroup config key to `eksctl`: - `--node-role-policies` for additional IAM policies added to the eksctl-managed node role. This just exposes the existing configuration key `attachPolicyARNs` for a little ease-of-use, like other advanced flags. - `--node-role-name` for specifying the exact name of the IAM role for nodes, as well as the corresponding nodegroup config key `instanceRoleName`. Resolves eksctl-io#398
Submitted a pull request for this #411. This is slightly off-topic but I'm pretty sure that you can use This isn't perfect but still allows you to provide your pods minimum privilege, without needs to deploy and operate an AWS IAM integration of your choice. |
This adds two flags and one nodegroup config key to `eksctl`: - `--node-role-policies` for additional IAM policies added to the eksctl-managed node role. This just exposes the existing configuration key `attachPolicyARNs` for a little ease-of-use, like other advanced flags. - `--node-role-name` for specifying the exact name of the IAM role for nodes, as well as the corresponding nodegroup config key `instanceRoleName`. Resolves eksctl-io#398
This adds two flags and one nodegroup config key to `eksctl`: - `--node-role-policies` for additional IAM policies added to the eksctl-managed node role. This just exposes the existing configuration key `attachPolicyARNs` for a little ease-of-use, like other advanced flags. - `--node-role-name` for specifying the exact name of the IAM role for nodes, as well as the corresponding nodegroup config key `instanceRoleName`. Resolves eksctl-io#398
This adds two flags and one nodegroup config key to `eksctl`: - `--node-role-policies` for additional IAM policies added to the eksctl-managed node role. This just exposes the existing configuration key `attachPolicyARNs` for a little ease-of-use, like other advanced flags. - `--node-role-name` for specifying the exact name of the IAM role for nodes, as well as the corresponding nodegroup config key `instanceRoleName`. Resolves eksctl-io#398
This adds two flags and one nodegroup config key to `eksctl`: - `--node-role-policies` for replacing the whole set of IAM policies associated to the eksctl-managed node role. This just exposes the existing configuration key `attachPolicyARNs` for a little ease-of-use, like other advanced flags. - `--node-role-name` for specifying the exact name of the IAM role for nodes, as well as the corresponding nodegroup config key `instanceRoleName`. This implicitly enable the `NamedIAM` cfn capability. Resolves eksctl-io#398
This adds two flags and one nodegroup config key to `eksctl`: - `--node-role-policies` for replacing the whole set of IAM policies associated to the eksctl-managed node role. This just exposes the existing configuration key `attachPolicyARNs` for a little ease-of-use, like other advanced flags. - `--node-role-name` for specifying the exact name of the IAM role for nodes, as well as the corresponding nodegroup config key `instanceRoleName`. This implicitly enable the `NamedIAM` cfn capability. The flags are marked hidden show that they are not shown in the command help. This is done to make it easier to be removed in near future. Resolves eksctl-io#398
This adds two flags and one nodegroup config key to `eksctl`: - `--node-role-policies` for replacing the whole set of IAM policies associated to the eksctl-managed node role. This just exposes the existing configuration key `attachPolicyARNs` for a little ease-of-use, like other advanced flags. - `--node-role-name` for specifying the exact name of the IAM role for nodes, as well as the corresponding nodegroup config key `instanceRoleName`. This implicitly enable the `NamedIAM` cfn capability. The flags are marked hidden show that they are not shown in the command help. This is done to make it easier to be removed in near future. Resolves eksctl-io#398
Bring Go to 1.13 in Travis
As described in https://github.com/weaveworks/eksctl/pull/381/files#r245498323, a feature that eases deploying kube2iam/kiam/kube-aws-iam-controller would be good to have.
Adding a flag like
--assume-role-access
alone is an incomplete solution to the problem, because making apps like kube2iam also requires you to set correct trust-relationship(or assume role policy document) to the roles "assumed by" the instance role.Adding a feature to eksctl that modifies assumed roles seems overkill and out-of-scope of the project.
Instead, I propose either of the belows:
--instance-role
that accepts an existing instance role arn. Also, an eksctl command that produces a cfn stack template containing the default eksctl instance role helps.--assume-role-access
or--instance-role-policy-arns
, and improveeksctl get nodegroup
to print the nodegroup info containing the instance role arn, in a data format helps integration with other tools. JSON would work.The text was updated successfully, but these errors were encountered: