Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask explicitly for config in issue templates #2738

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Ask explicitly for config in issue templates #2738

merged 2 commits into from
Oct 14, 2020

Conversation

michaelbeaumont
Copy link
Contributor

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont added the skip-release-notes Causes PR not to show in release notes label Oct 14, 2020
aclevername
aclevername approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbeaumont michaelbeaumont merged commit e3b9a35 into master Oct 14, 2020
@michaelbeaumont michaelbeaumont deleted the michaelbeaumont-patch-1 branch October 14, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclevername aclevername aclevername approved these changes

@cPu1 cPu1 Awaiting requested review from cPu1

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @aclevername