Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable use of existing subnets #305

Merged
merged 4 commits into from
Nov 7, 2018
Merged

Enable use of existing subnets #305

merged 4 commits into from
Nov 7, 2018

Commits on Nov 6, 2018

  1. Add logic to import subnets by IDs

    @errordeveloper
    errordeveloper committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    a2668d4 View commit details
    Browse the repository at this point in the history

  2. Remove redundant subnet validator

    @errordeveloper
    errordeveloper committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    192e63c View commit details
    Browse the repository at this point in the history

  3. Ensure subnet ref map is initialised

    @errordeveloper
    errordeveloper committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    46693a0 View commit details
    Browse the repository at this point in the history

  4. Add --vpc-{private,public}-subnets flags 

    - refactor conditional logic for readability
- add more flag compatibility validation
- print warning to ensure that configuring the
  VPC and subnets is user's responsibility
    @errordeveloper
    errordeveloper committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    d825a04 View commit details
    Browse the repository at this point in the history