only wait for addons to be healthy if atleast 1 node instance exists #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclevername
requested review from
cPu1,
Himangini,
nikimanoledaki and
Skarlso
aclevername
force-pushed
the
skip-addon-check
branch
from
50d325d
to
a969783
Compare
Skarlso
reviewed
Jan 14, 2022
| @@ -42,7 +42,7 @@ func CreateAddonTasks(cfg *api.ClusterConfig, clusterProvider *eks.ClusterProvid | |||
| clusterProvider: clusterProvider, | |||
| forceAll: forceAll, | |||
| timeout: timeout, | |||
| wait: len(cfg.NodeGroups) > 0 || len(cfg.ManagedNodeGroups) > 0, | |||
| wait: cfg.HasNodes(), | |||
Skarlso
reviewed
Jan 14, 2022
aclevername
force-pushed
the
skip-addon-check
branch
from
a969783
to
abf91ad
Compare
aclevername
force-pushed
the
skip-addon-check
branch
from
abf91ad
to
4b0f5f8
Compare
Skarlso
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4607
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯