Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait for aws-efs-csi-driver addon if cluster has no nodegroups #6960

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

TiberiuGC
Copy link
Collaborator

Description

Instead of cluster creation failing, the aws-efs-csi-driver should stay in degraded state until nodegroups are added.

Closes #6954

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC changed the title Don't wait for aws-efs-csi-driver if cluster has no nodegroups Don't wait for aws-efs-csi-driver addon if cluster has no nodegroups Aug 16, 2023
@TiberiuGC TiberiuGC marked this pull request as ready for review August 16, 2023 07:33
@TiberiuGC TiberiuGC requested review from Himangini and cPu1 and removed request for Himangini August 16, 2023 07:34
Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@TiberiuGC TiberiuGC enabled auto-merge (squash) August 16, 2023 15:02
@TiberiuGC TiberiuGC merged commit 299403d into eksctl-io:main Aug 16, 2023
9 checks passed
TiberiuGC added a commit to TiberiuGC/eksctl that referenced this pull request Aug 24, 2023
IdanShohamNetApp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cluster creation fails if no nodegroups and EFS csi addon required
3 participants