Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce eksctl Support Status Update on eksctl.io #7539

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

yuxiang-zhang
Copy link
Member

@yuxiang-zhang yuxiang-zhang commented Feb 7, 2024

Description

  • Update banner image
    • Make sure it shows up on home page
  • Update information on home page: new regions
  • Rename menu items:
    image
  • Allow collapsing sidebar items and reorder sidebar items:
    image

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@yuxiang-zhang yuxiang-zhang added the kind/docs User documentation label Feb 7, 2024
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about making a bit like:
Screenshot 2024-02-07 at 14 46 02

Maybe with a different text/background color but border-radius makes it easier to look at 😄

element {
  background-color: #2f4f864d;
  border-radius: 5px;
}

@a-hilaly
Copy link
Member

a-hilaly commented Feb 7, 2024

@yuxiang-zhang maybe we can give the full banner a light-orange-ish background color to bring users attention to it once they land on the page?

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yuxiang-zhang ! 👍

We can address the UX another day - looks like the full landing page needs to be reworked.

@yuxiang-zhang yuxiang-zhang merged commit 4e3d0e4 into eksctl-io:main Feb 7, 2024
12 checks passed
@yuxiang-zhang yuxiang-zhang deleted the update-layout branch February 7, 2024 21:49
@kingdonb
Copy link

kingdonb commented Feb 7, 2024

If the link to Weaveworks blog worked when you reviewed this, it does not work anymore, as https://weave.works is down

Edit: (looks like this update hasn't been deployed yet, sorry for the noise)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs User documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants