Add pluginlib support #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added plugin libraries to static linkage in native node.
adamantivm
approved these changes
Mar 10, 2017
| CountDownLatch latch = new CountDownLatch(1); | ||
| startParameterLoaderNode(latch); | ||
|
|
||
| while (latch.getCount() > 0) { |
There was a problem hiding this comment.
why a busy look here? Use the latch wait mechanism instead.
| try { | ||
| Thread.sleep(1000); | ||
| } catch (InterruptedException ie) { | ||
|
|
|
Thanks for the review; comments addressed! |
This was referenced Mar 10, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the plugin libraries to the static linkage list to use pluginlib support (valid since this PR was merged in roscpp_android).
It also proposes a fix to the race condition when loading parameters (move_base consumes the parameters before they are loaded into the server without this fix). This resolves #42.
Note:
ParameterLoaderNodecan be upstreamed once again and removed from the project once this is merged. This modification doesn't break the original API for the node.