Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal nginx config #54

Closed
wants to merge 2 commits into from
Closed

Conversation

muellerj
Copy link

First of all thanks for an amazing project. When I was setting this up on my own machine, I had to piece together some of the solutions in other issues, #27 being prominently helpful.

Maybe including a sample nginx config can help other people get set up faster.

@ekzhang
Copy link
Owner

ekzhang commented Nov 20, 2023

Thank you! Unfortunately I'm not super familiar with Nginx and am not able to adequately review this PR right now.

We can revisit in the future when we think about supporting self-hosting.

@ekzhang
Copy link
Owner

ekzhang commented Dec 28, 2023

Alright, unfortunately I'm closing this because the reverse proxy is only one part of a working self-hosted setup. In addition to the gRPC forwarding and TLS termination, you'll also need to set up:

  • private networking between instances
  • graceful shutdown
  • Redis server (if persisted, or doing a multi-server deployment)

Also this configuration hardcodes /sshx.SshxService/Channel, which isn't necessarily going to be the only gRPC streaming route. We'll want flexibility in the future to change this.

@ekzhang ekzhang closed this Dec 28, 2023
@muellerj
Copy link
Author

No worries - this was but my naïve attempt at getting this to work on my home box. If anyone has a more thorough/complete setup, I'm happy to switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants