Replace 'johnson' with ExecJS

[ArthurN]

In the process of trying to integrate therubyracer to support Ruby 1.9.2 per your blog comment, I ended up discovering ExecJS, which can work with any number of JS runtimes including both johnson and therubyracer. That seemed like the better solution, so here it is. As such, it ends up being up to the user of Isotope to select the runtime to work with ExecJS.

Additionally, I fixed a small bug in the spec (timezone-vs-UTC dates) and updated the Date.parse code to the latest version from this repo. The example application is also updated. I have NOT updated the Readme, however.

I've tested this with:
1.8.7 using johnson
1.8.7 using therubyracer
1.9.2 using therubyracer

on both the spec and the example app.

Cheers!

[elado]

Thanks!
Didn't have the chance to look deeper into the code, but the test succeeds on 1.8.7-p334 and fails on 1.9.2. Can you check?

$ rspec test/isotope_spec.rb 
rewriting path constants for test...
/Users/Elad/Sites/temp/isotope/test/isotope_spec.rb:7: warning: already initialized constant APP_ROOT
/Users/Elad/Sites/temp/isotope/test/isotope_spec.rb:8: warning: already initialized constant DEFAULT_CONFIG_PATH
.FF

Failures:

  1) Isotope should render articles
     Failure/Error: evaluated_content = Isotope.render_partial(@template_file, :locals => { :item => @articles[0] })
     ExecJS::ProgramError:
       ReferenceError: formatDate is not defined
     # ./lib/isotope/isotope.rb:44:in `render_partial'
     # ./test/isotope_spec.rb:45:in `block (2 levels) in <top (required)>'

  2) Isotope should render an array of articles
     Failure/Error: evaluated_content = Isotope.render_partial(@template_file, :collection => @articles, :delimiter => "<hr/>")
     ExecJS::ProgramError:
       ReferenceError: formatDate is not defined
     # ./lib/isotope/isotope.rb:44:in `render_partial'
     # ./lib/isotope/isotope.rb:57:in `block in render_partial_collection'
     # ./lib/isotope/isotope.rb:52:in `each'
     # ./lib/isotope/isotope.rb:52:in `render_partial_collection'
     # ./lib/isotope/isotope.rb:35:in `render_partial'
     # ./test/isotope_spec.rb:65:in `block (2 levels) in <top (required)>'

Finished in 0.1307 seconds
3 examples, 2 failures

[ArthurN]

What runtime are you using on 1.9.2, johnson or therubyracer?

Note that I intentionally did not require any runtime gem in isotope's Gemfile. My thinking was that the application will include whatever runtime it prefers in the Gemfile in addition to isotope itself. However, for simplicity's sake, we could just include 'therubyracer' in the isotope Gemfile. I'd have to double-check, but I think that ExecJS will prefer therubyracer over johnson if both are available on the system.

[ArthurN]

The reason I ask, of course, is because it seems to be working for me:

[507][arthur.Inception: isotope]$ rvm current
ruby-1.9.2-p180
[508][arthur.Inception: isotope]$ gem list | grep johnson
[509][arthur.Inception: isotope]$ gem list | grep rubyracer
therubyracer (0.9.3beta1, 0.9.2)
[510][arthur.Inception: isotope]$ rspec test/isotope_spec.rb 
rewriting path constants for test...
/Users/arthur/Projects/isotope/test/isotope_spec.rb:7: warning: already initialized constant APP_ROOT
/Users/arthur/Projects/isotope/test/isotope_spec.rb:8: warning: already initialized constant DEFAULT_CONFIG_PATH
...

Finished in 0.06601 seconds
3 examples, 0 failures

[elado]

OK, the problem was that I didn't have therubyracer gem on my 1.9. Please add it to the Gemfile and iI'll merge.
Thanks!

[ArthurN]

Will take care of that, as well as a small bug I discovered, tomorrow. Thanks!

[ArthurN]

Updated

[ArthurN]

Good call. Updated.