-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing export from python binding #190
Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 32 32
Lines 2913 2913
=======================================
Hits 2874 2874
Misses 39 39 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
We can use numpy array. https://pybind11.readthedocs.io/en/stable/advanced/pycpp/numpy.html More specifically, it should be something similar to manifold/bindings/python/pymanifold.cpp Lines 188 to 218 in 11e58ea
but we should flatten the buffer instead. |
@pca006132 Thanks, I think I've got all the python stuff working now, following your suggestion. I tried to install the python |
Try this:
it seems that they don't have it for 3.8. |
Perfect, thanks! |
@rsaccon This improved our python bindings considerably, which should make it a lot easier to integrate with Blender. Are you still interested in giving that a go? Would love to see that connection made. |
* try python meshio * removed meshIO dependency * fixed to_mesh * fix nix * more nix fix
Fixes #128
I found a nice little python library for import/export of various mesh formats: meshio. By removing this last dependency, we can separate our library completely from Assimp. However, this isn't yet functional because it seems the
to_mesh
function isn't working. I get the following Python error when I trypython3 run_all.py -e
:I think we need to convert our
std::vector<glm::vec3>
into a two-dimensional pythonlist
, but I'm not sure how to do that. Any thoughts @pca006132?UPDATE: working now.