Improve handling of invalid shape construction. #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 85.91% 86.04% +0.12%
==========================================
Files 36 36
Lines 4444 4485 +41
==========================================
+ Hits 3818 3859 +41
Misses 626 626
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
elalish
reviewed
Mar 22, 2023
elalish
approved these changes
Mar 22, 2023
Right, will do. |
|
I added an entry for |
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
Add `InvalidConstruction` to `Manifold::Error` and return empty manifolds with it set when manifold construction is attempted with invalid parameters - zero / negative dimensions for Cube - zero / negative radius for Sphere - zero / negative height for Extrude - empty CrossSection for Extrude/Revolve Also, Circle and Square have been updated to return empty CrossSections for similar arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #379
Error::InvalidConstruction, and add checks toManifoldconstructors that return empty manifolds with this error when given invalid arguments (such as negative radius)CrossSection, returning empty cross-sectionsCubewith negative dimensions, I noticed the semantic is to return mirrored cubes. To match this inCrossSection::Square, I added a check that reverses the winding of the path to make sure the shape is still positive.