Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor warp crash #442

Merged
merged 2 commits into from
May 27, 2023
Merged

Fix editor warp crash #442

merged 2 commits into from
May 27, 2023

Conversation

elalish
Copy link
Owner

@elalish elalish commented May 27, 2023

I was finding that warp would sometimes crash (saying something really unhelpful like out of memory) and then the editor was unusable until after a reload. I fixed this three ways:

  1. When the worker throws an error, we now recreate it, like when we cancel. This keeps the editor usable.
  2. I added our non-finite vertex check to Warp - turns out I was just generating a NaN somewhere.
  3. I surfaced this error through to throw in the JS bindings, so you actually get some feedback on what went wrong.

@elalish elalish self-assigned this May 27, 2023
@elalish elalish requested a review from geoffder May 27, 2023 05:34
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.04 ⚠️

Comparison is base (eb41b9d) 89.70% compared to head (f8fbb7f) 89.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   89.70%   89.67%   -0.04%     
==========================================
  Files          35       35              
  Lines        4237     4243       +6     
==========================================
+ Hits         3801     3805       +4     
- Misses        436      438       +2     
Impacted Files Coverage Δ
src/manifold/src/impl.h 72.72% <ø> (ø)
src/manifold/src/impl.cpp 95.36% <84.61%> (-0.36%) ⬇️
src/manifold/src/manifold.cpp 91.94% <100.00%> (-0.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elalish elalish merged commit 9dac47a into master May 27, 2023
@elalish elalish deleted the editorCrash branch May 27, 2023 05:37
@geoffder
Copy link
Collaborator

Was going to say I might not get to this and the rest of the other PR right away since I've got my bros wedding tomorrow, but you beat me to merging anyway! 😅

@elalish
Copy link
Owner Author

elalish commented May 27, 2023

Have fun! I'm out this weekend too, so wanted to merge this before I went to bed - more of an FYI in case I generated any merge conflicts for you.

@geoffder
Copy link
Collaborator

Roger, I'll plan to pull in master when I'm back at it for the formatting checks and these fixes.

@elalish elalish mentioned this pull request Nov 3, 2023
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
* reset errored worker

* catch non-finite warp errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants