3mf node export

[elalish]

This makes our 3MF export consistent with our GLB export when GLTFNode is used, creating the same scene hierarchy with mesh reuse. No materials yet, but we do include object names and a proper header.

This is blocked on hrgdavor/jscadui#37, which will need an npm release for us.

[elalish]

FYI @hrgdavor

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (7facd0e) 90.36% compared to head (bb5fd3c) 90.37%.
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   90.36%   90.37%           
=======================================
  Files          35       35           
  Lines        4431     4456   +25     
=======================================
+ Hits         4004     4027   +23     
- Misses        427      429    +2     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hrgdavor]

just released @jscadui/3mf-export/0.4.1 with changes incorporated.

I would like to point out that the export supports embedding a thumbnail, it would be cool if manifold would take advantage of that when exporting. There is example of it in the repo called testGen.js

there was a small bug introduced in to3dmodel ... parameter ...header was changed to header which is not correct ... header is supposed to pickup all other keys from the function options param, and fwd it.

[hrgdavor]

version change needed

[hrgdavor]

needs to be 0.4.2

[elalish]

there was a small bug introduced in to3dmodel ... parameter ...header was changed to header which is not correct ... header is supposed to pickup all other keys from the function options param, and fwd it.

Hmm, I actually changed that intentionally in order to make the header parameters work (and tested it). Since header is passed as a complete object to pushHeader, if you use ... you don't actually end up with a variable called header at all (you only get it's sub-members individually).

[hrgdavor]

What does your calling the function look like ? This dotted variant works in the test script within the package

[hrgdavor]

@elalish I checked the header parameter and the types you proposed. I agree with separating the header object instead of mixing the keys in the options.

v0.4.2 is published that is aligned with your call to to3dmodel that I also found more practical. I also separated out to3dmodelSimple variant of the function for cases where I have just set of meshes without a hiararchy (that is usual for jscad).
I transfered the proposed interfaces to jsdoc format with minor tweaks.

[elalish]

@hrgdavor Awesome, thank you! I'll get back to this shortly, but I need to go to a wedding first.

[elalish]

@pca006132 Did you say something about a problem with the windows TBB build?

[pca006132]

yes, maybe we can disable it for now until I find a way to fix it.

[elalish]

It's already marked "not required", so I guess it's fine for the moment. Ideally we should scope down this CI list a bit (if we go full TBB) and make all the remaining ones required.