-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: use GCC 14 in Linux build #816
Conversation
Interesting, I guess file an issue on Clipper2? Or is this a problem in our own CMake? |
I've built locally with that Clipper2 snapshot, but installing into my system first before building Manifold. So I wasn't expecting this - but haven't had time to look yet either. |
Interesting, I think the clipper2 update is separate from the GCC update. I forgot a lot of cmake trickeries now, need to check if the best solution is to fix things here or ask upstream to have a single export. |
I've dropped the clipper2 update commit in favour of #817. |
5c59da3
to
05b0391
Compare
Compiling on GCC 14 after #817 merged but lcov fails linux-test-project/lcov#296
|
I think it is fine to disable lcov for GCC 14 for now? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 91.84% 89.21% -2.63%
==========================================
Files 37 61 +24
Lines 4976 8467 +3491
Branches 0 930 +930
==========================================
+ Hits 4570 7554 +2984
- Misses 406 913 +507 ☔ View full report in Codecov by Sentry. |
Ubuntu 24.04 packages GCC 13. GitHub add GCC 14 to their runner.
Processing ./test/CMakeFiles/manifold_test.dir/smooth_test.cpp.gcno geninfo: ERROR: mismatched end line for _ZN23Smooth_Tetrahedron_Test8TestBodyEv at /home/runner/work/manifold/manifold/test/smooth_test.cpp:26: 26 -> 39 (use "geninfo --ignore-errors mismatch ..." to bypass this error)
Looking more closely it was actually GCC 13 that was failing (GCC 14 job hadn't got that far). It passes if Then needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Ubuntu 24.04 packages GCC 13. GitHub add GCC 14 to their runner.
There are now some CMake issues to sort out with the Clipper2 snapshot!