Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playlists API service endpoint #17

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

dennis531
Copy link
Collaborator

@dennis531 dennis531 commented Mar 6, 2024

The added Playlist API Endpoint is based on the opencast pull request with the playlists.

@ferishili ferishili marked this pull request as ready for review March 8, 2024 15:15
@ferishili
Copy link
Contributor

Hi @dennis531,
thank you very much for your contribution, would you mind adding the whole documentation to the GitHub wiki as well?
Please take a look at the /api/** endpoints here: https://github.com/elan-ev/opencast-php-library/wiki/API-Endpoints

@ferishili
Copy link
Contributor

ferishili commented Mar 8, 2024

The Unit tests are failing, I would assume that is because of the version increment to 1.11.0 which is not yet provided by stable.opencast.org, therefore we need to make sure that version is only changed to 1.11.0 inside the OcPlaylistsApiTest and handle the checkers and exceptions there!

@dennis531
Copy link
Collaborator Author

After the OC pull request is merged, I will add the wiki entry and implement the version handling in the tests. Perhaps the API could still change.

The playlists api is supported since api version v1.11.0
@dennis531
Copy link
Collaborator Author

Now the playlist test checks if the configured opencast has support for the playlists api. If not supported, the tests will be skipped.

@dennis531
Copy link
Collaborator Author

The playlists api is documented at https://github.com/elan-ev/opencast-php-library/wiki/OcPlaylistsApi.

@dennis531 dennis531 self-assigned this Mar 26, 2024
@dennis531
Copy link
Collaborator Author

dennis531 commented Mar 26, 2024

@ferishili you have to add the library version in https://github.com/elan-ev/opencast-php-library/wiki/OcPlaylistsApi#version when you create a new library version.

Edit: I added version 1.6

@ferishili
Copy link
Contributor

ferishili commented Apr 24, 2024

Hi @dennis531
Thank you very much for your contribution.
Everything looks good

@ferishili ferishili merged commit 361348d into elan-ev:master Apr 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants