Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering to main search #1063

Open
LukasKalbertodt opened this issue Jan 10, 2024 · 2 comments
Open

Add filtering to main search #1063

LukasKalbertodt opened this issue Jan 10, 2024 · 2 comments
Labels
area:search Related to Tobira's search kind:new-feature A new feature

Comments

@LukasKalbertodt
Copy link
Member

Big question is how complex we want to make the filter system. For now (and maybe forever), we don't want a full blown super complex system with arbitrary AND/OR/NOT operators and stuff. Main focus for now should be to cover the main use cases and have a UI that's simple to use. We can make it more powerful in the future, but we should always keep it easy to use. Hiding expert features if necessary.

TODO: elaborate further, list some things to filter for. Ole already started something. I want to take a look at that before writing stuff from scratch here.

@LukasKalbertodt LukasKalbertodt added kind:new-feature A new feature area:search Related to Tobira's search labels Jan 10, 2024
@oas777
Copy link
Collaborator

oas777 commented Jan 10, 2024

Keep in mind one "separate" filter might be the source of data (DC metadata vs. slides vs. transcripts) to distinguish from "search all sources" - results of that filter have to be filtered further with the "original" filters (date/semester, language, access).

@oas777
Copy link
Collaborator

oas777 commented Jan 10, 2024

PS: "access" meaning open access vs. protected content.

LukasKalbertodt added a commit that referenced this issue Mar 12, 2024
This adds a first iteration of basic filters for item type ("all",
"videos", "pages") and time frame.
There are some open questions regarding how to deal with pages while the
time filter is active, since pages do not have a timestamp. This means
they are not affected by the filter.

Lukas and I decided to split to reworking of the search into multiple
PRs with incremental improvements and features added. This is now only
laying the foundation for these work packages, and will not change
anything visible for now.
Filters are included but hidden behind the `tobiraExperimentalFeatures`
flag (this is mainly information for developers).

Part of #1063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:search Related to Tobira's search kind:new-feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants