Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting videos in Tobira #806

Closed
oas777 opened this issue May 3, 2023 · 3 comments · Fixed by #1172
Closed

Deleting videos in Tobira #806

oas777 opened this issue May 3, 2023 · 3 comments · Fixed by #1172
Assignees
Labels
area:backend Everything backend related area:frontend Everything frontend related area:sync Syncing with an Opencast instance kind:new-feature A new feature

Comments

@oas777
Copy link
Collaborator

oas777 commented May 3, 2023

David: "When users or admins delete a page in Tobira or unmount a series in an existing page in Tobira what expectation do they have considering the links they have shared to the videos of this series? I assume that they assume that these links too stop working. But maybe I'm wrong."

@oas777
Copy link
Collaborator Author

oas777 commented May 3, 2023

I would argue for a distinction between deletion of pages on the one hand, videos on the other:

Deleting pages in Tobira will not delete videos and the users should be made aware that videos are not deleted. And could still be available with a "Direktlink/Videolink" - especially if we decide that the "Seitenlink" will be forwarded to a "Direktlink/Videolink" in case the page has been deleted.

Deleting videos should be allowed only in the "My videos" section, but for that, we first need to tackle that page so that it also displays "My series" for them to be deleted (instead of deleting each video...).

@LukasKalbertodt LukasKalbertodt added area:backend Everything backend related area:frontend Everything frontend related kind:new-feature A new feature area:sync Syncing with an Opencast instance labels May 8, 2023
@oas777
Copy link
Collaborator Author

oas777 commented May 15, 2023

David:

I'm still quite skeptical that this (a link to a "video in page context" falls back to the direct link, when a page no longer exists) is a good idea. Because, if I get it right, with the now implemented solution I have to delete or unpublish a video I had once inserted on a page and shared via link in order to prevent people from being able to access this video. It is not enough to take it away from this page or to delete the page.

In fact, I picture a lot of users expecting the following:

I have shared a link to a video in a page context.
I delete this page or remove the shared video from this page (for example because it is outdated) because people should not be able to see it anymore (for example because it is outdated).
Then people following the link I shared should NOT be able to see the video anymore.

@oas777
Copy link
Collaborator Author

oas777 commented May 15, 2023

More thoughts:

  • When and where will pages be deleted? On the "institutional level", this doesn't happen very often, it will be more regular on the "users pages" if users created a page "My videos for this semester's course".
  • When deleting an institutional page (end of project etc.), you probably don't want to delete video automatically (!). The user would probably expect his videos to also be deleted. So we need an UI anyway to not only inform them but to make a decision.
  • In your pages, you can embed "your videos" (owner) and videos that have ACL allowing them to be shared. The former can be deleted when deleting a page, the latter cannot. So more decision-making in the UI...

@oas777 oas777 added this to Tobira Jun 8, 2023
@LukasKalbertodt LukasKalbertodt moved this to Todo in Tobira Apr 10, 2024
@owi92 owi92 self-assigned this May 2, 2024
@owi92 owi92 moved this from Todo to In Progress ⏳ in Tobira May 8, 2024
@LukasKalbertodt LukasKalbertodt moved this from In Progress ⏳ to In Review 👀 in Tobira Jun 18, 2024
LukasKalbertodt added a commit that referenced this issue Jun 20, 2024
This adds a "delete" button to the "Video details" page which will
remove that event in Tobira and send a `delete` request to Opencast.
While that operation is pending and when it fails on Opencast side, the
event will still be visible on the "My Videos" page marked respectively,
but only there and only as long as it is still present in Opencast.
Tobira's sync code will pick up if it gets eventually deleted, and then
the "pending/ deletion failed" event will be removed completely.

See commits for more technical details.
Should be fine to review commit by commit.

Closes #806
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✔️ in Tobira Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:backend Everything backend related area:frontend Everything frontend related area:sync Syncing with an Opencast instance kind:new-feature A new feature
Projects
Status: Done ✔️
Development

Successfully merging a pull request may close this issue.

3 participants