Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic search filters (experimental) #1080

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Add basic search filters (experimental) #1080

merged 7 commits into from
Mar 12, 2024

Commits on Mar 7, 2024

  1. Debounce search 

    This adds a slight delay before starting the search
while typing.
    @owi92
    owi92 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e3f3d53 View commit details
    Browse the repository at this point in the history

  2. Add search item type filter 

    This adds filters to show either videos or pages
exclusively. When we add more item types in the future,
we might want to consider to allow to combine filters,
i.e. showing both series and videos but not pages, or any
other combination.
    @owi92
    owi92 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5613d5d View commit details
    Browse the repository at this point in the history

  3. Add date range filter 

    While there are nice libraries for this, they are
either quite large, unmaintained or don't work out
of the box, so I built a simple component for this
myself, though that is neither super fancy nor pretty.
    @owi92
    owi92 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d6868c0 View commit details
    Browse the repository at this point in the history

  4. Italicise search term in breadcrumbs

    @owi92
    owi92 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5fa6360 View commit details
    Browse the repository at this point in the history

  5. Move filtering to backend & use URL search params 

    For now, the filters are hidden behind the `experimentalFeatures`
flag. They are to be extended and or redone in the future, but
the aim of this commit is to lay the foundation for that.
    @owi92
    owi92 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    6fcd050 View commit details
    Browse the repository at this point in the history

  6. Show correct number of filtered search results 

    Previously the numbers of total hits were bunched
together regardless of the selected filter. Now it
only shows the number of the filtered results.
    @owi92
    owi92 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    253d88d View commit details
    Browse the repository at this point in the history

  7. Adjust search UI test 

    This PR slightly changes the breadcrumb formatting,
so that needed to get adjusted accordingly in the
respective UI test.
    @owi92
    owi92 committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    fbf74da View commit details
    Browse the repository at this point in the history