Enables i18ned footer links #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the footer custom link type from `string` to `TranslatedString`, enabling links to resources, especially documents like PDFs, in different languages with just one link.
There was a problem hiding this comment.
That feature makes sense to me! I would still assume that many of those footer entries will only have one link for all languages. And this is a breaking change (which is fine, but slightly annoying to update). Could you make Tobira accept both in the config, a translated map or a simple string? I think it should work with sth like:
#[derive(Deserialize)]
#[serde(untagged)]
enum OptionallyTranslatedString {
Translated(TranslatedString),
Simple(String)
}But I'm not 100% sure. If you can't get it to work quickly, just ping me then either I can try or we can just merge this as is.
Make the translated links optional, as breaking changes in the config is annoying.
|
Initially, I tried to alter the deserialization with Serde to automatically translate a string to a map with an |
LukasKalbertodt
requested changes
Feb 26, 2024
Extend the footer_inks example to showcase both ways of declaring custom links and extending the description.
LukasKalbertodt
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the footer custom link type from
stringtoTranslatedString, enabling links to resources, especially documents like PDFs, in different languages with just one link.