Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation for invalid realm paths #1204

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

LukasKalbertodt
Copy link
Member

@LukasKalbertodt LukasKalbertodt commented Jul 9, 2024

We screwed this up in c502b43. Weird how I only noticed this now.

@LukasKalbertodt LukasKalbertodt added kind:bug Bug changelog:user User facing changes labels Jul 9, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1204 July 9, 2024 17:53 Destroyed
@owi92
Copy link
Member

owi92 commented Jul 11, 2024

Unknown user realm paths like @{some_unknown_user} will still show the management nav, is that intended?

@LukasKalbertodt
Copy link
Member Author

Ohh good catch, that is not intended.

@owi92
Copy link
Member

owi92 commented Jul 11, 2024

well I messed this up the first time around, might as well double check now :D

We screwed this up in c502b43. Weird
how I only noticed this now.
@github-actions github-actions bot temporarily deployed to test-deployment-pr1204 July 11, 2024 09:36 Destroyed
Copy link
Member

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 just waiting for CI to finish

@owi92 owi92 merged commit 17e9c04 into elan-ev:master Jul 11, 2024
3 checks passed
@LukasKalbertodt LukasKalbertodt deleted the fix-nav branch July 11, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes kind:bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants