Various fixes and improvements #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We decided to trust the "start time" and ignore streams that start early.
Unfortunately, Paella does not auto play the stream yet as far as I can tell. And I haven't found any way to enable autoplay.
This required quite a bit of shuffling code around in `Video.tsx` but I am happy with the end result as it doesn't repeat too much code.
|
🚀 This PR was deployed at https://pr505.tobira.opencast.org. The deployment will be updated whenever someone pushes onto this PR's branch. |
JulianKniephoff
requested changes
Aug 9, 2022
JulianKniephoff
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits. Can be reviewed individually. Only for the last commit for
Video.tsx: look at the final code rather than the super noisy diff.A screenshot of the new "broken thumbnail" look:
The big player replacement for upcoming live streams: