Hide player for ended streams and make video blocks also hide the player sometimes #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic was just moved to the `Player` component. Also, the props of `Player` were somewhat simplified by grouping most into one `event` prop that can be passed more easily.
LukasKalbertodt
force-pushed
the
hide-player-after-enddate
branch
from
b4735ad
to
f9c8e65
Compare
|
🚀 This PR was deployed at https://pr521.tobira.opencast.org. The deployment will be updated whenever someone pushes onto this PR's branch. |
frontend/src/ui/player/index.tsx
Outdated
| if (event.isLive && hasEnded === false) { | ||
| handles.push(setTimeout(onEventStateChange, endTime.getTime() - Date.now() + 500)); | ||
| } | ||
| return () => handles.forEach(handle => clearTimeout(handle)); |
There was a problem hiding this comment.
Suggested change
| return () => handles.forEach(handle => clearTimeout(handle)); | |
| return () => handles.forEach(clearTimeout); |
This is very similar to the one appearing before a live-stream has started.
LukasKalbertodt
force-pushed
the
hide-player-after-enddate
branch
from
f9c8e65
to
bf3dad2
Compare
JulianKniephoff
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.