Add ability to show series description in series block (plus various other things) #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was surprisingly missing until now. The API returning an error and the log not mentioning it at all is confusing.
It's arguably the main thing to choose there. The other things are just options for displaying.
I think it looks a bit cleaner and less crammed.
LukasKalbertodt
added
changelog:user
|
🚀 This PR was deployed at https://pr532.tobira.opencast.org. The deployment will be updated whenever someone pushes onto this PR's branch. |
JulianKniephoff
requested changes
Aug 29, 2022
frontend/src/routes/manage/Realm/Content/Edit/EditMode/Series.tsx
Outdated
Show resolved
Hide resolved
JulianKniephoff
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
mountSeries(i.e. Admin UI) default to showing no title and the description, making for a more useful page.I intended to also put nice icons for the four different layouts into the selection thingies. But I decided not to do that now in the interest of time. (But that what mainly made me design this other kind of radio button thingy.)
Please see commits. They can be reviewed individually.