Clean up local store mods when navigating away from realm editor #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 This PR was deployed at https://pr536.tobira.opencast.org. The deployment will be updated whenever someone pushes onto this PR's branch. |
Comment on lines
104
to
109
| const router = useRouter(); | ||
| useEffect(() => ( | ||
| router.listenAtNav(() => { | ||
| onCancel?.(); | ||
| }) | ||
| )); |
There was a problem hiding this comment.
Can't you just do this?
Suggested change
| const router = useRouter(); | |
| useEffect(() => ( | |
| router.listenAtNav(() => { | |
| onCancel?.(); | |
| }) | |
| )); | |
| useEffect(() => () => onCancel?.()); |
Fixes elan-ev#457 and some related bugs.
JulianKniephoff
force-pushed
the
fix-leaving-realm-editor
branch
from
ffd3dd8
to
6ea5709
Compare
LukasKalbertodt
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457 and some related bugs.