Apply login page redesign #721
Conversation
There was a problem hiding this comment.
Mhhh not a fan of having a login button in the header still. I would suggest waiting for #702 and then taking a look at this again. I would think if we want the header, the login button should be hidden. Which would leave:
- Logo: ok, I can see its use, its easier to use than the "back" button I suppose
- Search bar: I really can't imagine someone needing to search from the login page
- Language menu: That actually makes sense.
Mh dunno, I guess it makes sense to have the header on the login page then :/ Still not 100% convinced, but can't put my finger on it. Without the login button it's likely fine. Again, let's wait for #702 and see about this then.
owi92
force-pushed
the
redesign-login-page
branch
from
b195808
to
8374536
Compare
This is a slight variation of the previous design featuring a different login button, the addition of the header and removal of the logo, since that is included in the header. It adds a specific `loginMode` to the header component which only shows the logo and language selection.
owi92
force-pushed
the
redesign-login-page
branch
from
8374536
to
9c69712
Compare
|
The last commit should fix the search bar |
owi92
force-pushed
the
redesign-login-page
branch
from
4a9fec9
to
4957ddc
Compare
This replaces `width: 100%` with `flex: 1` and declares the input containing label as flex container. This way, the search bar can actually shrink before the logo when the screen is resized. Though that only becomes apparent with a larger max-width (eg 600px or so) of the searchbar than we use now.
owi92
force-pushed
the
redesign-login-page
branch
from
4957ddc
to
0e475bf
Compare
This is a slight variation of the previous design, featuring a different login button, the addition of the header and removal of the logo, since that is included in the header.