Use searchable series select in series block edit UI #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the previous bad UI that just listed all series in a single select. Series were added to the index some time ago.
4 tasks
owi92
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
I found nothing wrong with the code, but I noticed the wave plugin complaining about two errors with the new select field. It appears to be missing a form label and the contrast between the "select option..." placeholder and its background is not high enough.
This wasn't introduced with this PR but with #705, at least that's my guess.
I am creating a separate issue for this as I wouldn't say it needs to be fixed in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the previous bad UI that just listed all series in a single select. Series were added to the index some time ago.
Fixes #373
Well, there are still some possible improvements listed there but I think it's fair to close it. The event part of this was done previously already.
This is required for user realms as in those, non-moderators need to be able to edit realm content, which is impossible with the
allSeriesAPI we had before.