Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumbs to all pages (excluding homepage) #780

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Apr 14, 2023

This removes the logo tooltip and adds breadcrumbs to the about tobira, create user realm, login, page not found and search result pages. When there is no sidebox navigation, the breadcrumbs are aligned like they would be on smaller screens, i.e. with the upper left corner of the containing element.

Closes #750

@github-actions github-actions bot temporarily deployed to test-deployment-pr780 April 14, 2023 15:00 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Just a small CSS thing.

frontend/src/routes/Login.tsx Outdated Show resolved Hide resolved
frontend/src/routes/NotFound.tsx Show resolved Hide resolved
@LukasKalbertodt LukasKalbertodt added the changelog:user User facing changes label Apr 17, 2023
@owi92 owi92 force-pushed the add-breadcrumbs-to-all-pages branch from 3894064 to 66b8ca6 Compare April 17, 2023 12:43
@github-actions github-actions bot temporarily deployed to test-deployment-pr780 April 17, 2023 12:47 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny thing 🙈

frontend/src/routes/Login.tsx Outdated Show resolved Hide resolved
This removes the logo tooltip and adds breadcrumbs to the `about tobira`,
`create user realm`, `page not found` and `search result` pages.
When there is no sidebox navigation, the breadcrumbs are aligned
like they would be on smaller screens, i.e. with the upper left corner of
the containing element.
@owi92 owi92 force-pushed the add-breadcrumbs-to-all-pages branch from 66b8ca6 to f38219b Compare April 17, 2023 13:40
@github-actions github-actions bot temporarily deployed to test-deployment-pr780 April 17, 2023 13:45 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit 5ddd079 into elan-ev:master Apr 17, 2023
@owi92 owi92 deleted the add-breadcrumbs-to-all-pages branch March 4, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure to have breadcrumbs on every page to not rely on the logo-home-link
2 participants