Drop PostgreSQL 10 support and fix user session query #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elan-ev#776 I also checked and haven't found any other `extract` usage that we haven't fixed yet.
PG 10 is EOL for some time already so we don't need to test against that anymore. But further, there have been a number of cases where subtle breaking changes in newer PG versions broke Tobira for those versions. Ideally of course we have a perfect test suite and run it for all supported PG versions. We do not have that, however. So the next best idea is: let devs use the newest PG version locally and let the test deployment server use the oldest supported PG version. Then hopefully these bugs are noticed earlier. To be clear: we support all PG versions that are still officially supported, which at this time, are PG11 - 15. Loading DB dumps created with PG 10 still works. For devs: you need to remove the volume containing your old DB as otherwise PG 15 will not start. I'm sure there are better ways but I did it like this: `docker-compose down --volumes`.
See previous commit: 10 is EOL, so we don't need to check it. CI wants to check with the oldest supported PG version. Loading the DB dump unfortunately generates some warnings which lead to a non-0 error code. But the import is fine, so we sadly have to ignore the error code.
LukasKalbertodt
force-pushed
the
fix-and-upgrade-pg
branch
from
e83895a
to
f577b81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #748
Fixes #776
See commit messages for further information.
What's still missing: update the test deployment server to PG10 and then creating all DB dumps with PG11. However, we currently have tons of open PRs and I don't want to upgrade PG on the test server now :D #784