-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code to regularly send basic statistics to Opencast for adopter registration #878
Conversation
ffcb5ac
to
bb3df90
Compare
Question about the version data: Do you anticipate a lot of self-builds? Can we just track the tag or hash? Edit: Also, |
Are you asking this to simplify version handling? So I know that at least one organization uses custom patches. The commit gives us more information than the version (same commit means same version, but same version can be used in different commits). I expect that all Tobiras in production will have
Oh yeah, you're correct. I'm can never remember the nuanced meaning of those two words. Will change. |
Ok, let's keep the version data then :) The linked server-side PR currently expects the following format sent to Opencast:
There's a |
The other statistics data from Opencast also uses snake_case.
576ed1d
to
af8a775
Compare
I added a commit regarding |
af8a775
to
d64757e
Compare
Related Opencast PR: opencast/opencast#5040
Still draft as there are open questions and this does not yet work with above PR.
I think the statistics sent here are very basic and don't contain any too sensitive data. And in any case, the data is only sent outside of ones installation if they agreed to sharing basic data as part of the adopter registration. Otherwise it's completely discarded/unused. And sending it from Tobira to Opencast is also no problem as that connection needs to be private anyway, as all Opencast data will go through it. So I don't see how anyone could have a privacy concern regarding this. See the structs at the bottom of
stats.rs
to see what exactly is sent.