Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark series field as required for upload #887

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Mark series field as required for upload #887

merged 1 commit into from
Jun 26, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Jun 22, 2023

Fixes #886

@owi92 owi92 added the changelog:user User facing changes label Jun 22, 2023
LukasKalbertodt
LukasKalbertodt requested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether the field is required or not depends on the config. See a few lines further up: CONFIG.upload.requireSeries. So your additions should be conditional.

@github-actions github-actions bot temporarily deployed to test-deployment-pr887 June 22, 2023 14:29 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr887 June 22, 2023 14:40 Destroyed
LukasKalbertodt
LukasKalbertodt requested changes Jun 22, 2023
View reviewed changes
frontend/src/routes/Upload.tsx Outdated Show resolved Hide resolved
frontend/src/routes/Upload.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to test-deployment-pr887 June 22, 2023 15:44 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit 0a68a5c into elan-ev:master Jun 26, 2023
2 checks passed
@owi92 owi92 deleted the series-field-requirement branch March 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt approved these changes

Assignees
No one assigned
Labels
changelog:user User facing changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Video upload: Also indicate "Serie" as "required"
2 participants
@owi92 @LukasKalbertodt