-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust grey tones (add new ones and change brightness values) #900
Conversation
This is in an attempt to unify grey value across all our apps.
Thumbs up from me. Concerning the naming/numeration-issue, I have no strong opinion. |
All changes, except for `color.tsx` are completely automated by using LSP rename functionality.
Now the style declarations are on the element itself, not via some weird selectors.
Internally the grey tones were also accepted, so we will go ahead with them. Regarding the naming question: we decided for the alternative naming (closer to brightness values). The main argument was: we will work with the Figma design files for a while now, and then likely never again. So the "closer to Figma color names" is only a temporary advantage. And having more uniform names is nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking this over. I mean, I was satisfied with my version, but I do see the benefits of (a) your version and (b) you being the one implementing it ;)
This is in an attempt to unify grey tones across all our apps. I think this new 12 tone palette is a good, actually, given all the constraints we had and properties we wanted to optimize for.
Short recap: Tobira organically developed some grey tones during development; then Lisa's suggested a design for editor, studio and Tobira, which also had a palette of grey tones. Of course, those two sets of greys were not the same. So we decided to unify it and once and for all just set a fixed set of grey tones for these three applications, and for our applications in the future. This set shouldn't have too many colors, shouldn't have too few, should be close enough to Lisa's set so that it's easy looking up colors from the Figma, should be close to Tobira's set so that Tobira still works.
I decided for the values you see in the PR's diff. Here is a visualization of the brighter half of the light mode values:
Note how Tobiras grey0 and grey1 both map to neutral10. Both colors were never used next to one another (the contrast would be way too low). And I think the distinction there was really not necessary. So I think that's totally fine and even good that we have one tone fewer in Tobira!
Regarding naming: the PR as is uses the name of the closest Lisa grey. This has the advantage that if we check the designs in Figma, and we see an element with neutral200, we can just use our neutral20 color and get almost the same value, i.e. no need to think about anything. The disadvantage is that the numbers do not reflect brightness values at all; and we have no n15. I would much prefer the alternative naming shown in the image above, which would change the name of four colors. That way, we have n05, n10, n15, n20, n25, n30 and then we start with a step size of 10. That's much better than just randomly having n25 and n35, but no n15. Also, the brightness difference in the alternative names between n05, n10, n15, n20, n25, and n30 is almost constant (only increases slowly in one direction). And then the distance between n30, n40, n50 ... n90 is also fairly constant again. But the disadvantage: looking at Figma, seeing neutral200 or neutral300, those wouldn't map to neutral20 or neutral30 anymore, but to neutral15 and neutral25 respectively.
I also adjusted the dark mode values a bit such that they have more regular step sizes. The most notable change is that the series-block background got a bit darker. I don't mind that and might actually prefer it? But let me know what you think.
(Once everyone is happy with the colors, I will also refactor the frontend so that the fields of the
COLORS
constant are also calledneutralXX
.)