Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed background/color for inputs and textareas #939

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Sep 19, 2023

Closes #932

I noticed that disabled textareas also use a slightly greyed-out font-color, so I added this effect to disabled inputs as well.

@github-actions github-actions bot temporarily deployed to test-deployment-pr939 September 19, 2023 14:25 Destroyed
@owi92 owi92 added the changelog:nope Not worth mentioning in the changelog label Sep 19, 2023
@LukasKalbertodt
Copy link
Member

Mh, it looks good but I'm thinking whether it could look even better. You chose a flat look with the inputs having the same background color as the background. If we compare to GitHub:

image
image

There the input is slightly darker than the background. I'm not sure about light mode, but in dark mode I kinda like it. But of course, you are already using the darkest color we have :D So before we somehow introduce a darker color... would we even want to? Does anyone else agree even darker is nice?

Example (via dev tools):

image

vs

image

What do you think?

@owi92
Copy link
Member Author

owi92 commented Sep 20, 2023

I think darker is nice but I'm not sure if we really want to add another color for that. Also not sure about light mode, but I'm leaning towards keeping it flat on that side.

@github-actions github-actions bot temporarily deployed to test-deployment-pr939 September 20, 2023 12:29 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit 4974312 into elan-ev:master Sep 20, 2023
3 checks passed
@owi92 owi92 deleted the fixed-background-for-inputs branch March 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:nope Not worth mentioning in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input fields and textareas have no defined background color, making it browser-dependent
2 participants