Unify focus style on miscellaneous elements #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
added
changelog:user
LukasKalbertodt
requested changes
Oct 16, 2023
Unfortunately, we can't use our focus style everywhere. There are some special cases where the offset would collide with `overflow: hidden` and therefore be clipped. So in these cases, they need a workaround. I had to fiddle around a bit with paddings and margins, so the enclosed/focused element has some space between inself and the focus border. Sometimes `outlineOffset` would work in theory, but then there would be too much space at the top and bottom and not enough on the sides (subjectively speaking).
The header menus didn't show any focus style because we didn't specify Tobira's `focus` color for appkit.
I'm not sure why this didn't work before, as the other
"wrapperless" menuitems in language and color menu are
very much tabbable (is that a word?). Anyway this adds
a `div` wrapper with a `tabindex={0}` to make it keyboard
reachable again.
owi92
force-pushed
the
moar-focus-style
branch
from
607add6
to
e41ec7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Closes #663