Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain volume setting across all videos #983

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Retain volume setting across all videos #983

merged 1 commit into from
Nov 8, 2023

Conversation

owi92
Copy link
Member

@owi92 owi92 commented Nov 3, 2023

Closes #979

@owi92 owi92 added the changelog:user User facing changes label Nov 3, 2023
@github-actions github-actions bot temporarily deployed to test-deployment-pr983 November 3, 2023 11:24 Destroyed
@github-actions github-actions bot temporarily deployed to test-deployment-pr983 November 7, 2023 17:50 Destroyed
LukasKalbertodt
LukasKalbertodt approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the key that Paella uses (preferences|{}), but doesn't seem like we can easily improve that. Oh well. Seems to work, so yay, better UX!

@LukasKalbertodt LukasKalbertodt merged commit e2ddff0 into elan-ev:master Nov 8, 2023
2 checks passed
@owi92 owi92 deleted the retain-paella-volume branch March 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt approved these changes

Assignees
No one assigned
Labels
changelog:user User facing changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loudness/volume is not remembered
2 participants
@owi92 @LukasKalbertodt