Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover all ES Date Formats #5

Closed
KodrAus opened this issue Dec 26, 2015 · 3 comments
Closed

Cover all ES Date Formats #5

KodrAus opened this issue Dec 26, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@KodrAus
Copy link
Member

KodrAus commented Dec 26, 2015

The date parser needs to provide the current implementation as a default for Format implementations, but also them to override it where the situation is unique, such as with epoch_millis where there's no equivalent chrono format.

  • Move parsing onto the Format trait
  • Provide a standard implementation
  • Overload where necessary
  • Ensure the date parser is complete and doesn't produce unexpected results (such as parsing just a . as milliseconds)
@KodrAus
Copy link
Member Author

KodrAus commented Jan 30, 2016

The Format trait also needs to specify a format method that takes a DateTime and produces a string.

Adding epoch_millis would be a good start since it will probably be the most efficient method to parse.

@KodrAus
Copy link
Member Author

KodrAus commented Feb 7, 2016

epoch_seconds will be a worthwhile forma tot have too since it'll provide the speed of millis, but without the imprecision at dates before/close to 1970.

@KodrAus KodrAus modified the milestones: 0.3, Future Feb 11, 2016
@KodrAus KodrAus modified the milestones: 0.2 - Types, 0.3 - Rotor Mar 13, 2016
@KodrAus KodrAus added the easy label Apr 3, 2016
@KodrAus
Copy link
Member Author

KodrAus commented Apr 3, 2016

Other date formats should be fairly easy to add now. Any date mappings that require changing the parse logic, or where there isn't some chrono format that covers it should be opened as separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant