Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: properly set recording status when store apm span to otel #1477

Closed
wants to merge 1 commit into from
Closed

FIX: properly set recording status when store apm span to otel #1477

wants to merge 1 commit into from

Conversation

wzy9607
Copy link

@wzy9607 wzy9607 commented Jun 28, 2023

close #1476

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 28, 2023

💚 CLA has been signed

@wzy9607 wzy9607 changed the title FIX: properly set recording status when store apm span to otel FIX: properly set recording status when store apm span to otel, close #1476 Jun 28, 2023
@wzy9607 wzy9607 changed the title FIX: properly set recording status when store apm span to otel, close #1476 FIX: properly set recording status when store apm span to otel Jun 28, 2023
@wzy9607 wzy9607 marked this pull request as ready for review June 28, 2023 04:21
@dmathieu
Copy link
Member

Thank you for the fix. The problem here is that while the span is marked as recording, it's unusable, since it's a noop.
If we provide a recording span, we should be able to set its attributes.

I have opened #1478.
However, it's not fully synced with the agent's spans/transactions. So if you create a span with the agent, then retrieve it using otel and make changes to it, and finally close the agent one, the changes made on the otel side won't be saved.

@dmathieu
Copy link
Member

dmathieu commented Jul 3, 2023

We decided to go with #1478.

@dmathieu dmathieu closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants